Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync "Most Used" and "All Categories" tabs when using classic editor #7810

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link

Trac ticket:https://core.trac.wordpress.org/ticket/62440

Description:

This PR addresses a bug where the "Most Used" category tab was not synced with the "All Categories" tab in the Classic Editor. When selecting categories in the "Most Used" tab, the changes were not reflected in the "All Categories" tab, causing inconsistency in category selection.

Fix:

  • Added functionality to ensure the category selection in the "Most Used" tab correctly updates the "All Categories" tab.
  • Updated the event listeners to ensure proper syncing of checkbox states between the two tabs.
  • The issue occurred because the 'All Categories' section had a suffix appended to it, as shown in the screenshot below.
Screenshot 2024-11-15 at 7 06 06 PM

Steps to Test:

  1. Open the Classic Editor in WordPress.
  2. Go to the "Categories" section.
  3. Select a category from the Most used section.
  4. Notice that the category won't be checked in the "All categories" section.
  5. Their is No sync between categories checked in the "Most used" section and "All categories" section

Video demonstration

Before:

Screen.Recording.2024-11-15.at.7.00.29.PM.mov

After:

Screen.Recording.2024-11-15.at.7.02.31.PM.mov

Copy link

github-actions bot commented Nov 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props im3dabasia1, azaozz.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@azaozz
Copy link
Contributor

azaozz commented Nov 15, 2024

Hi @im3dabasia, thanks for the patch. Seems to work well here.
This is a super old JS. Pushed couple of small changes: limit it only to input elements as it was matching li too, also shortened it a bit. Please see if it still works well. This seems to also work with the previous HTML IDs so if someone is using a custom walker class, it won't break.

@im3dabasia
Copy link
Author

Hi @im3dabasia, thanks for the patch. Seems to work well here. This is a super old JS. Pushed couple of small changes: limit it only to input elements as it was matching li too, also shortened it a bit. Please see if it still works well. This seems to also work with the previous HTML IDs so if someone is using a custom walker class, it won't break.

I tested it, and it works as expected. Thanks for the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants