wp_audio_shortcode() outputs invalid HTML

[shubham07kb]

wp_audio_shortcode() was chaging boolean attributes to 1, as of true === 1, in debug i notice it was directly happening after foreach, not by eascaping, so I have add a if statement to handle boolean attributes and directly pass our key, as Key can be directly work for boolean attributes in HTML.

Trac Ticket: https://core.trac.wordpress.org/ticket/61515

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shub07, narenin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[narenin]

Hi @shubham07kb

The PR looks good to me.

[dmsnell]

It looks like all this is doing is generating an HTML <audio> tag. What if instead of sticking with the old pattern and adjusting it for a very specific purpose, we replaced the generation with the use of the HTML API/

Is it correct that these values are the PHP boolean values true? If so, the HTML API will add them as boolean attributes, or if they are false, will automatically not add them.

$audio_tag_builder = new WP_HTML_Tag_Processor( '<audio controls>' );
$audio_tag_builder->next_tag();
foreach ( $html_attrs as $name => $value ) {
	$audio_tag_builder->set_attribute( $name, $value );
}

$html .= $audio_tag_builder->get_updated_html();