-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Use Script Modules data filter #6683
Interactivity API: Use Script Modules data filter #6683
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
c07dd24
to
f57725f
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@luisherranz @cbravobernal @DAreRodz I'd love to get an Interactivity API review of this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂
Good trick to update the JS handle beforehand 😄
Use the "script_module_data_@wordpress/interactivity" filter to pass Script Module data to the Interactivity API client.
41388bf
to
d51b1ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Suggested commit message:
|
A dedicated API exists for passing data to Script Modules implemented in changeset [58579]. Use this Core API instead of a custom implementation for Interactivity API to pass data to the client. Developed in #6683. Props jonsurrell, gziolo, luisherranz, cbravobernal. Fixes #61512. git-svn-id: https://develop.svn.wordpress.org/trunk@58729 602fd350-edb4-49c9-b593-d223f7449a82
Committed to Core in https://core.trac.wordpress.org/changeset/58729. |
A dedicated API exists for passing data to Script Modules implemented in changeset [58579]. Use this Core API instead of a custom implementation for Interactivity API to pass data to the client. Developed in WordPress/wordpress-develop#6683. Props jonsurrell, gziolo, luisherranz, cbravobernal. Fixes #61512. Built from https://develop.svn.wordpress.org/trunk@58729 git-svn-id: http://core.svn.wordpress.org/trunk@58131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A dedicated API exists for passing data to Script Modules implemented in changeset [58579]. Use this Core API instead of a custom implementation for Interactivity API to pass data to the client. Developed in WordPress/wordpress-develop#6683. Props jonsurrell, gziolo, luisherranz, cbravobernal. Fixes #61512. Built from https://develop.svn.wordpress.org/trunk@58729 git-svn-id: https://core.svn.wordpress.org/trunk@58131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
A dedicated API exists for passing data to Script Modules implemented in changeset [58579]. Use this Core API instead of a custom implementation for Interactivity API to pass data to the client. Developed in WordPress#6683. Props jonsurrell, gziolo, luisherranz, cbravobernal. Fixes #61512. git-svn-id: https://develop.svn.wordpress.org/trunk@58729 602fd350-edb4-49c9-b593-d223f7449a82
https://core.trac.wordpress.org/changeset/58579 introduced an API for passing data to Script Modules similar to what Interactivity API does.
Instead of its own implementation, change the Interactivity API to use the Core API via the
script_module_data_{$module_id}
filter.Todo:
✅
This will not work until client scripts are updated. The@wordpress/interactivity
Script Module was updated in WordPress/gutenberg#61658 to try to get client data from an updated element ID. This requires@wordpress/interactivity@>5.7.0
.Trac ticket: https://core.trac.wordpress.org/ticket/61512
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.