-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for associative and indexed array arguments when rescheduling a cron event #6504
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM with a naming things fix.
Pre-approving as the main purpose of this is working as expected.
@@ -488,7 +488,10 @@ public function test_pre_reschedule_event_filter() { | |||
add_filter( 'pre_reschedule_event', '__return_true' ); | |||
|
|||
// Reschedule event with preflight filter in place. | |||
wp_reschedule_event( $ts1, 'daily', $hook ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Blame Wilson... :)
Co-authored-by: Peter Wilson <[email protected]>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/57271
I had a suspicion that using an associative array for the args for a cron event (despite not technically being allowed, they do work) was a cause of the rescheduling failures reported in #57271. It looks like that's not the case, but here are some tests anyway.