Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for associative and indexed array arguments when rescheduling a cron event #6504

Closed
wants to merge 4 commits into from

Conversation

johnbillion
Copy link
Member

@johnbillion johnbillion commented May 4, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/57271

I had a suspicion that using an associative array for the args for a cron event (despite not technically being allowed, they do work) was a cause of the rescheduling failures reported in #57271. It looks like that's not the case, but here are some tests anyway.

Copy link

github-actions bot commented May 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM with a naming things fix.

Pre-approving as the main purpose of this is working as expected.

tests/phpunit/tests/cron.php Outdated Show resolved Hide resolved
tests/phpunit/tests/cron.php Outdated Show resolved Hide resolved
@@ -488,7 +488,10 @@ public function test_pre_reschedule_event_filter() {
add_filter( 'pre_reschedule_event', '__return_true' );

// Reschedule event with preflight filter in place.
wp_reschedule_event( $ts1, 'daily', $hook );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Blame Wilson... :)

@johnbillion
Copy link
Member Author

@johnbillion johnbillion closed this May 6, 2024
@johnbillion johnbillion deleted the 57271 branch May 6, 2024 18:48
Copy link

github-actions bot commented May 6, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants