Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh - Validate URL in Locate Template #6502

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

shail-mehta
Copy link
Member

Added refresh patch for Validate url in locate template.

Trac ticket: https://core.trac.wordpress.org/ticket/58905

Copy link

github-actions bot commented May 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, mukesh27, martinkrcho.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta changed the title Validate URL in Locate Template Refresh - Validate URL in Locate Template May 4, 2024
Copy link

github-actions bot commented May 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@shail-mehta shail-mehta force-pushed the validate-url-in-locate-template branch from d3ff41f to 8ae3447 Compare May 5, 2024 08:59
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will impact the performance.

break;
} elseif ( $is_child_theme && file_exists( $wp_template_path . '/' . $template_name ) ) {
} elseif ( $is_child_theme && file_exists( $template ) && 0 === validate_file( $template ) ) {
$located = $wp_template_path . '/' . $template_name;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simplified a bit.

Suggested change
$located = $wp_template_path . '/' . $template_name;
$located = $template;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinkrcho Thanks for the feedback. I have added suggested changes in latest commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link

@martinkrcho martinkrcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants