Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert #117 #118

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Partially revert #117 #118

merged 6 commits into from
Jun 6, 2024

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Jun 6, 2024 •
edited
Loading

There's more nuance to the type of the returned value than #117 antitipated. With that PR in, WooCommerce wouldn't work:

[06-Jun-2024 16:21:26 UTC] PHP Fatal error:  Uncaught TypeError: get_object_vars(): Argument #1 ($object) must be of type object, string given in /wordpress/wp-includes/class-wpdb.php:3
Stack trace:
#0 /wordpress/wp-includes/class-wpdb.php(3): get_object_vars('wp_wc_product_a...')
#1 /wordpress/wp-content/plugins/woocommerce/src/Internal/ProductAttributesLookup/LookupDataStore.php(69): wpdb->get_var('SHOW TABLES LIK...')
#2 /wordpress/wp-content/plugins/woocommerce/src/Internal/ProductAttributesLookup/LookupDataStore.php(650): Automattic\WooCommerce\Internal\ProductAttributesLookup\LookupDataStore->check_lookup_table_exists()

Let's revert and revisit later on

cc @bgrgicak @wojtekn

@adamziel
Partially revert #117
926178e 
There's more nuance to the type of the returned value than #117 antitipated. With that PR in, WooCommerce wouldn't work:

```
[06-Jun-2024 16:21:26 UTC] PHP Fatal error:  Uncaught TypeError: get_object_vars(): Argument #1 ($object) must be of type object, string given in /wordpress/wp-includes/class-wpdb.php:3
Stack trace:
```

Let's revert and revisit later on
@adamziel
Restore previous test
554342e
@adamziel
Revert wp-includes/sqlite/class-wp-sqlite-translator.php
13e58d7
@adamziel
Merge branch 'main' into rever-117
e8ea916
@adamziel
cbf
95724b4
@adamziel
Restore previous logic
ed7b29d
@adamziel adamziel merged commit b74ae19 into main Jun 6, 2024
9 checks passed
@aristath aristath deleted the rever-117 branch June 10, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adamziel