Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra blocks to navigation block - Heading , Paragraph and Image #68268

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

benazeer-ben
Copy link
Contributor

What?

Fixes #46256

Why?

As per the issue mentioned in the ticket, Currently, we can only add menu links and the social block to the navigation menu, which is limiting for designers - especially for mobile menus. Many platforms allow for multiple types of content to be displayed throughout a menu.

How?

Adding support for Heading, Paragraph, Image to navigation block.

Testing Instructions

  • Open page/post in edit mode.
  • Add navigation block.
  • Try to add other blocks by clicking on Add block
  • Verify Paragraph, Heading and Image blocks available in the list.
  • Verify these newly added blocks are working fine in frontend and editor.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshare.-.2024-12-24.5_02_10.PM.mp4

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Menrath.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Menrath.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: mrfoxtalbot <[email protected]>
Co-authored-by: uniquesolution <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: bradhogan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow heading, image, and paragraph blocks within Navigation block
1 participant