Show metabox when pattern is accessed directly #68255
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
This issue first appeared in WP 6.7, and since this PR is relatively small, it might be worth backporting to WP 6.7. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +14 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 51661b6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12476275877
|
stokesman
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick fix for #67902
What? / Why?
The meta box that appears when you navigate to the pattern editor in the post editor is tied to the post editor, not the pattern. This was reported as confusing, so it was fixed in #64990. This PR removes the meta box from always appearing when editing a pattern.
However, as reported in #67902, we found that there are cases where you want to apply meta data to the pattern itself. And since a pattern is a kind of post type, you can edit the pattern directly via
/wp-admin/edit.php?post_type=wp_block. This PR renders the meta box only when the pattern is accessed directly.How?
Ideally, the meta box itself would be reloaded (re-rendered) when you navigate to a pattern in the post editor, but as mentioned in this comment, that's a bit tricky.
For now, we check
onNavigateToPreviousEntityRecordto see if the pattern was accessed directly.Testing Instructions
Testing Instructions for Keyboard
/wp-admin/edit.php?post_type=wp_blockand select the sync pattern you just created.