Revert "Skip failing image block test (#62781)" #62854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
kevin940726
force-pushed
the
fix/reenable-skipped-image-test
branch
from
5df5b9c
to
01e62ec
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kevin940726
changed the title
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
|
Thanks Kai! 🙇 |
|
🤔 It failed again. |
|
Very strange! I've tested out a fresh WP 6.6 RC 1 install, and it seems the crop is failing there, too, even though it contains the revert. 2024-06-26.13.50.32.mp4The request being sent to the media/edit endpoint is the same in 6.5 + Gutenberg as 6.6 RC 1, so I'm not sure what's going on. I'll create a separate Github issue. |
|
Added an issue here: #62855 |
|
Update: I think I found the culprit. Added a comment over on the issue: #62855 (comment) — TL;DR, I believe it was trac ticket 59782 in the end. Potential fix over in: WordPress/wordpress-develop#6909 |
Mamaduka
approved these changes
Jun 26, 2024
|
Update: WordPress/wordpress-develop#6909 has landed in I've kicked off the e2es again so let's see what happens 😄 |
This reverts commit 7f40c68.
andrewserong
force-pushed
the
fix/reenable-skipped-image-test
branch
from
01e62ec
to
92c072a
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…2854) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: andrewserong <[email protected]> This reverts commit 7f40c68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Continued from #62781. Re-enable the skipped image e2e test.
Why?
Now that the upstream commit has been reverted, we can reenable this test to help us catch some regressions.
How?
Re-enable the test by removing
test.skip.Testing Instructions
CI should pass.
Screenshots or screencast
N/A