Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section Styles: improve performance and conceptual consistency #62712

Merged
merged 35 commits into from
Jun 24, 2024
Merged

Section Styles: improve performance and conceptual consistency #62712

merged 35 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. Remove variation style registration from theme json and theme style v… 

    …ariations
    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6b10584 View commit details
    Browse the repository at this point in the history

  2. Make variation style registration specific to partials

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fbb6775 View commit details
    Browse the repository at this point in the history

  3. Inject partial theme.json variations before filters

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e00fbfd View commit details
    Browse the repository at this point in the history

  4. Remove existing filters that resolve shared definitions

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    87b5be2 View commit details
    Browse the repository at this point in the history

  5. Unwrap shared variation definitions within theme json constructor

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6001757 View commit details
    Browse the repository at this point in the history

  6. Remove retrieval of user origin data in block style variations test

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    82efc17 View commit details
    Browse the repository at this point in the history

  7. Remove styles.blocks.variations from internal schema

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    18c0636 View commit details
    Browse the repository at this point in the history

  8. Add unit test for unwrapping shared definitions

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b738360 View commit details
    Browse the repository at this point in the history

  9. Fix injection of variation partials data

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    28ce75e View commit details
    Browse the repository at this point in the history

  10. Fix block style registry variations

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9b41371 View commit details
    Browse the repository at this point in the history

  11. Make registry variations be overridden by partials again

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ffe3db8 View commit details
    Browse the repository at this point in the history

  12. Fix global styles API test

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0242883 View commit details
    Browse the repository at this point in the history

  13. Fix copy paste docblock

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e980752 View commit details
    Browse the repository at this point in the history

  14. Switch to directly registering variations from partials

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0d86f4b View commit details
    Browse the repository at this point in the history

  15. Fix typo

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    77e9f50 View commit details
    Browse the repository at this point in the history

  16. Try removing blockTypes from shared variation definitions

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    eb78e91 View commit details
    Browse the repository at this point in the history

  17. Update testing grounds

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    39920cc View commit details
    Browse the repository at this point in the history

  18. Merge top & block level data instead of block registry data

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5f146c8 View commit details
    Browse the repository at this point in the history

  19. Make linter happy

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d8b0335 View commit details
    Browse the repository at this point in the history

  20. Update PHP docblock

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    20f2754 View commit details
    Browse the repository at this point in the history

  21. Process variations from block styles registry.

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    016f7ba View commit details
    Browse the repository at this point in the history

  22. Make linter happy

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7b9a2fe View commit details
    Browse the repository at this point in the history

  23. Add backport

    @oandregal @aaronrobertshaw
    oandregal authored and aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4d56029 View commit details
    Browse the repository at this point in the history

  24. Fix minor nits

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2e04467 View commit details
    Browse the repository at this point in the history

  25. Remove extraneous whitespace

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    681741f View commit details
    Browse the repository at this point in the history

  26. Add test for variation styles merge order

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7626433 View commit details
    Browse the repository at this point in the history

  27. Prevent partial styles overriding registered variation for different … 

    …block
    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d77a6b0 View commit details
    Browse the repository at this point in the history

  28. Fix test_add_registered_block_styles_to_theme_data

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d781aed View commit details
    Browse the repository at this point in the history

  29. Update unwrapping to include variations for core blocks not in registry

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e33638f View commit details
    Browse the repository at this point in the history

  30. Fix typo

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ba38fa3 View commit details
    Browse the repository at this point in the history

  31. Add since comment for change to theme json constructor

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    37f6865 View commit details
    Browse the repository at this point in the history

  32. Try relocating variations in theme.json schema 

    This might end up being removed to deemphasize its availability.
    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e90b542 View commit details
    Browse the repository at this point in the history

  33. Remove title and block types from shared definitions

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    af5b180 View commit details
    Browse the repository at this point in the history

  34. Remove title from translatable theme.json schema

    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b7013f8 View commit details
    Browse the repository at this point in the history

  35. Ensure block style variations are registered when retrieving theme st… 

    …yle variations
    @aaronrobertshaw
    aaronrobertshaw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1e0065e View commit details
    Browse the repository at this point in the history