Merge of the 146 and 142 themes #222
Conversation
Combination of the two branches with some slight adjustment based off of feedback and my own assessment confirmed working on local
Preview changesI've detected changes to the following themes in this PR: Poetry, Purr. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
poetry/patterns/single.php
Outdated
| /** | ||
| * Title: single | ||
| * Slug: poetry/single | ||
| * Categories: hidden |
There was a problem hiding this comment.
we don't add categories if the pattern is hidden (it doesn't exist as a default category and if we wanted to create one, we would have to register it first)
|
|
||
| <!-- wp:group {"style":{"spacing":{"blockGap":"8px"},"elements":{"link":{"color":{"text":"var:preset|color|vivid-red"}}}},"layout":{"type":"flex","flexWrap":"nowrap"}} --> | ||
| <div class="wp-block-group has-link-color"><!-- wp:paragraph {"textColor":"custom-contrast"} --> | ||
| <p class="has-custom-contrast-color has-text-color">By</p> |
There was a problem hiding this comment.
can you check if running npm run escape:patterns on this PR escapes the strings on this pattern? It's not a blocker
poetry/patterns/single.php
Outdated
|
|
||
| <!-- wp:group {"style":{"spacing":{"padding":{"right":"56px","left":"56px"},"blockGap":"32px"},"border":{"left":{"width":"2px"}}},"layout":{"type":"flex","orientation":"vertical","flexWrap":"nowrap"}} --> | ||
| <div class="wp-block-group" style="border-left-width:2px;padding-right:56px;padding-left:56px"><!-- wp:image {"id":15,"width":"56px","height":"56px","sizeSlug":"full","linkDestination":"none"} --> | ||
| <figure class="wp-block-image size-full is-resized"><img src="<?php echo esc_url(get_stylesheet_directory_uri()); ?>/assets/images/feather-small.png" alt="" class="wp-image-15" style="width:56px;height:56px" /></figure> |
There was a problem hiding this comment.
Check the guidelines for pattern creation:
To create dynamic image links in your block patterns, utilize the
get_template_directory_uri()function. This function retrieves the URL of the current theme's directory, ensuring that the image links are relative to the theme and work correctly even if the website's directory structure changes or if we are using a child theme. This is essential for maintaining the stability and portability of your patterns.
| <!-- /wp:group --> | ||
| </div> | ||
| <!-- /wp:group --> | ||
|
|
There was a problem hiding this comment.
I would expect to see the comments block somewhere around here for the single posts template
|
I like the idea that the page would show a featured image and no longer has the left column, but I don't think singular is the right template for it. If we look at the template hierarchy I think page.html makes more sense and it's something users are more used to |
|
I would like to see #179 merged and have that header used for this templates, since the header we are using is way too big and probably should only be used for the home page |
|
Actioning this today and tomorrow :D |
Going off feedback, actioning most of the notes previously on PR #222
Combination of the two branches with some slight adjustment based off of feedback and my own assessment confirmed working on local