Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Poetry: 404 and search templates #145

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

thetwopct
Copy link
Collaborator

@thetwopct thetwopct commented Mar 7, 2024

#130

404

Screenshot-2024-03-07 --13 51 45

I gave it a poetry-esque 404 message.

Search

Screenshot-2024-03-07 --14 07 17

The loop results uses the same style as the index page, but looks like this needs some adjustment to the column/group widths to stop the date wrapping?

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking nice! I added a few comments. I think we can follow up on the issue with the date on a separate PR.

<div class="wp-block-group">
<!-- wp:group {"style":{"spacing":{"blockGap":"88px"}},"layout":{"type":"flex","orientation":"vertical"}} -->
<div class="wp-block-group">
<!-- wp:site-title {"level":0,"isLink":false,"style":{"typography":{"fontSize":"24px","fontStyle":"normal","fontWeight":"600"}},"textColor":"custom-text"} /-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to keep the header element like the index.html template has it. It's more consistent between pages and also we need to keep the header element for accessibility reasons. This comment goes for both templates

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I forgot the header in poetry was super huge. My recommendation still remains, let's make a secondary header pattern or template part to reuse in internal pages that doesn't have the huge text, but let's keep it consistent between pages. And let's use the tagName header on it so we don't miss the header element

</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","theme":"poetry","tagName":"footer","area":"footer"} /-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both templates should have a footer element. We can go without the area attribute (the theme.json file already includes this info) and the theme slug (it will make the template part break if the theme is installed in a subfolder)


<!-- wp:group {"tagName":"main","backgroundColor":"custom-background-light","layout":{"contentSize":null,"type":"constrained"}} -->
<main class="wp-block-group has-custom-background-light-background-color has-background">
<!-- wp:query {"queryId":0,"query":{"perPage":10,"pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true,"taxQuery":null,"parents":[]},"tagName":"main","layout":{"contentSize":null,"type":"constrained"}} -->
Copy link
Collaborator

@MaggieCabrera MaggieCabrera Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this Query block should look the same as the one in the index template, what about we make it into a pattern instead and then we avoid duplicating code over both templates? (that way when we fix the problem with the date we only change it in one place)

@MaggieCabrera MaggieCabrera linked an issue Apr 5, 2024 that may be closed by this pull request
@iamsam2e iamsam2e self-assigned this May 16, 2024
First part of this commit - addressing feedback to keep the header element consistent between the 404 template and the index template for better accessibility.
@MaggieCabrera
Copy link
Collaborator

@samtoohey93 be careful here because this needs a rebase

@iamsam2e
Copy link
Collaborator

iamsam2e commented May 17, 2024

Ah damn sorry I was doing this rushing out the door this arvo 🤦‍♂️
I'm back in office Monday, I'll fix this. Apologies.

iamsam2e added a commit that referenced this pull request May 30, 2024
Rebased from PR 145, to resolve issues for the 404 template as suggested my MC as well as resolving accidental push onto the existing #145 branch

this resolves both #144 and #145
@iamsam2e iamsam2e mentioned this pull request May 30, 2024
@iamsam2e iamsam2e added question Further information is requested Theme: Poetry labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Theme: Poetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry: 404 and search
3 participants