Remove unused variables from a few sniffs #2514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes three instances where a variable was passed to `preg_match()` as the third parameter to fill it with the results of the search, but later it was not used.
This commit removes the unnecessary initialization of the variable `$end` at the beginning of the sniff code. Every single `case` statement of the `switch` that follows either re-initialize the variable with a different value or returns without using the variable.
jrfnl
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM. Thanks @rodrigoprimo!
For context regarding the $matches parameters in preg_match() calls: prior to PHP 5.4, the $matches parameter was a required parameter when calling preg_match_all(), so this is likely a left-over loosely related to that (from when PHP 5.3 was still supported).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2513 (comment), this PR removes unused variables detected automatically using PHPStorm code inspection from a few sniffs.
I have checked that the removed variables do not trigger errors at PHPStan levels higher than what we are currently using and that the modified code has at least minimal test coverage.
@dingo-d, in the screenshot that you shared in #2513 (comment),
EnqueuedResourcesSniff.phpis included, but I was not able to find any unused variables in this file.