Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPCSExtra to v1.1.1 #2387

Closed
wants to merge 1 commit into from
Closed

Update PHPCSExtra to v1.1.1 #2387

wants to merge 1 commit into from

Conversation

dingo-d
Copy link
Member

@dingo-d dingo-d commented Sep 13, 2023

No description provided.

@dingo-d dingo-d added this to the 3.x Next milestone Sep 13, 2023
@dingo-d dingo-d mentioned this pull request Sep 13, 2023
Merged
36 tasks
@dingo-d dingo-d self-assigned this Sep 13, 2023
jrfnl
jrfnl approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is good, but not strictly necessary. The 1.1.1 release doesn't add anything WPCS relies on nor fixes bugs in sniffs WPCS uses.

GaryJones
GaryJones requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.1.1 release doesn't add anything WPCS relies on nor fixes bugs in sniffs WPCS uses.

Since WordPressCS doesn't need 1.1.1, then we should keep the constraint wider.

Suggest Close.

@dingo-d dingo-d closed this Sep 13, 2023
@GaryJones GaryJones deleted the feature/update-composer-packages branch September 13, 2023 11:40
@jrfnl jrfnl removed this from the 3.0.1 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones requested changes

@jrfnl jrfnl jrfnl approved these changes

Assignees

@dingo-d dingo-d

Labels
Meta: Repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dingo-d @GaryJones @jrfnl