Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding to the readme and add funding file #2372

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

dingo-d
Copy link
Member

@dingo-d dingo-d commented Aug 28, 2023

For the FUNDING.yml file, I'm not 100% sure if we can link to the specific subpage, or will this work only with

open_collective: thewpcc

@dingo-d dingo-d added this to the 3.x Next milestone Aug 28, 2023
@dingo-d dingo-d self-assigned this Aug 28, 2023
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dingo-d Looking good, just one small suggestion.

@@ -0,0 +1 @@
open_collective: thewpcc/contribute/wp-php-63406
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not sure if this will work, what about using the custom: LINK1 format ? That should work for sure.

Ref: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking about that. Should I leave the open collective link to point to the thewpcc, and add the custom link?

@jrfnl
Copy link
Member

jrfnl commented Aug 28, 2023

As a general question: should there be a "This project needs funding" banner or something near the top of the README for visibility ?

Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nitpick comments, but looking good.
Q: Should the section be added to the table of contents ?

@GaryJones As the PR has changed substantially, do you want to take another look ?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dingo-d
Copy link
Member Author

dingo-d commented Aug 30, 2023

Q: Should the section be added to the table of contents?

I don't think so, not sure if it's relevant for some SEO purposes, but it's at the top of the readme, so it's pretty visible, no?

@jrfnl
Copy link
Member

jrfnl commented Sep 3, 2023

@GaryJones Could you please have another look (as the PR has changed significantly) ? If okay, please feel free to merge.

@dingo-d dingo-d requested a review from GaryJones September 4, 2023 15:35
@dingo-d dingo-d force-pushed the feature/update-funding-page branch 2 times, most recently from fd680bd to 3a1fb69 Compare September 9, 2023 18:34
Add the funding link and section in the readme.
Add the link to the v3 release make post in the readme.
Add the FUNDING.yml file so that we can add the funding button in the repo.

Co-authored-by: Juliette <[email protected]>
@dingo-d dingo-d force-pushed the feature/update-funding-page branch from 3a1fb69 to fe4fa45 Compare September 9, 2023 18:39
README.md Outdated Show resolved Hide resolved
Co-authored-by: Gary Jones <[email protected]>
@dingo-d dingo-d requested a review from GaryJones September 10, 2023 09:24
@GaryJones GaryJones merged commit 4367be3 into develop Sep 10, 2023
34 checks passed
@GaryJones GaryJones deleted the feature/update-funding-page branch September 10, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants