-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add funding to the readme and add funding file #2372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dingo-d Looking good, just one small suggestion.
.github/FUNDING.yml
Outdated
@@ -0,0 +1 @@ | |||
open_collective: thewpcc/contribute/wp-php-63406 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're not sure if this will work, what about using the custom: LINK1
format ? That should work for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking about that. Should I leave the open collective link to point to the thewpcc, and add the custom link?
As a general question: should there be a "This project needs funding" banner or something near the top of the README for visibility ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nitpick comments, but looking good.
Q: Should the section be added to the table of contents ?
@GaryJones As the PR has changed substantially, do you want to take another look ?
I don't think so, not sure if it's relevant for some SEO purposes, but it's at the top of the readme, so it's pretty visible, no? |
@GaryJones Could you please have another look (as the PR has changed significantly) ? If okay, please feel free to merge. |
fd680bd
to
3a1fb69
Compare
Add the funding link and section in the readme. Add the link to the v3 release make post in the readme. Add the FUNDING.yml file so that we can add the funding button in the repo. Co-authored-by: Juliette <[email protected]>
3a1fb69
to
fe4fa45
Compare
Co-authored-by: Gary Jones <[email protected]>
For the FUNDING.yml file, I'm not 100% sure if we can link to the specific subpage, or will this work only with