Documentation Class Instantiation #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
requested changes
Sep 23, 2019
There was a problem hiding this comment.
@FORTE-WP Hi Frank, thank you for this PR! Looking good.
I've left some minor, mostly grammatical, remarks inline.
Other than that, I also noticed there is trailing whitespace after the description in each of the <standard> blocks.
Aside from that, all looks good.
| </code_comparison> | ||
| <standard> | ||
| <![CDATA[ | ||
| Don't use spaces between object name and open parenthesis when instantiating new object. |
There was a problem hiding this comment.
Suggested change
| Don't use spaces between object name and open parenthesis when instantiating new object. | |
| Don't use spaces between the object name and the open parenthesis when instantiating new object. |
| ]]> | ||
| </standard> | ||
| <code_comparison> | ||
| <code title="Valid: no spaces between object name and parenthesis."> |
There was a problem hiding this comment.
Suggested change
| <code title="Valid: no spaces between object name and parenthesis."> | |
| <code title="Valid: no whitespace between the object name and the parenthesis."> |
| $a = new Foobar(); | ||
| ]]> | ||
| </code> | ||
| <code title="Invalid: spaces between object name and parenthesis."> |
There was a problem hiding this comment.
Suggested change
| <code title="Invalid: spaces between object name and parenthesis."> | |
| <code title="Invalid: a space between the object name and the parenthesis."> |
| <code_comparison> | ||
| <code title="Valid: object instantiation without reference."> | ||
| <
|
I just processed all feedback from jrfnl in a new commit. |
jrfnl
approved these changes
Sep 28, 2019
|
Thank you @FORTE-WP for making those changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1722