Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/WordPress.WhiteSpace.DisallowInlineTabs #1735

Merged
merged 7 commits into from
Jul 18, 2019
Merged

Docs/WordPress.WhiteSpace.DisallowInlineTabs #1735

merged 7 commits into from
Jul 18, 2019

Conversation

ckanitz
Copy link
Contributor

@ckanitz ckanitz commented Jun 20, 2019

Adds documentation for the WordPress.WhiteSpace.DisallowInlineTabs

Related to #1722

ckanitz added 2 commits July 2, 2019 10:55
@ckanitz
add spaces to indent array items
3ab2746
@ckanitz
add <em> wrapper, shortned example strings
7ff4dd4 
Too shorten the strings was neccessary as it would "break" the terminal table
jrfnl
jrfnl requested changes Jul 11, 2019
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckanitz Hi Christopher, thank you for this PR and for the updates already made.

Very nearly there, just one tiny typo and one minor clarification.

I look forward to merging this soon!

WordPress/Docs/WhiteSpace/DisallowInlineTabsStandard.xml Outdated Show resolved Hide resolved
WordPress/Docs/WhiteSpace/DisallowInlineTabsStandard.xml Outdated Show resolved Hide resolved
@ckanitz
Copy link
Contributor Author

ckanitz commented Jul 15, 2019

hi @jrfnl I commited the changes as requested :)

ckanitz
ckanitz commented Jul 15, 2019
View reviewed changes
Copy link
Contributor Author

@ckanitz ckanitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix description text*

jrfnl
jrfnl approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for bearing with us and for contributing!

@jrfnl
Copy link
Member

jrfnl commented Jul 15, 2019

@GaryJones Did you still want to have a second look or shall I Squash/Merge this ?

@jrfnl jrfnl dismissed GaryJones’s stale review July 18, 2019 04:42

Remarks have been addressed

@jrfnl jrfnl merged commit 13a8bc1 into WordPress:develop Jul 18, 2019
@jrfnl jrfnl added this to the 2.x Next milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

@GaryJones GaryJones GaryJones left review comments

Assignees
No one assigned
Labels
Type: Documentation
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ckanitz @jrfnl @GaryJones