Add support for higher basegame SFX IDs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluenaxela
reviewed
May 10, 2023
| { | ||
| curRoot = PGE_SDL_Manager::appPath; | ||
| for(int i=0; i<91; i++) | ||
| for(int i = 0; i < max_soundeffect_count; i++) |
There was a problem hiding this comment.
This is not safe/correct code. i is used to index into defaultChunksList and chunksChannelsList which have a size of defaultSoundCount, which may be smaller than max_soundeffect_count when this is called.
There was a problem hiding this comment.
I just did a commit fixing the issue where channelChunksList doesn't have any values above 91. Anything above 91 will take the channel -1.
Check it and see if it's good enough, if you have the time to.
… just use -1 as the channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another pull request that handles adding more than 91 sound IDs for sound effects. Requires a line change in main.lua (Line 284). Just delete off
and soundIdx <= 91on that line and you're good to go!Code is based off saturnyoshi's code pertaining to higher basegame music IDs.