Skip to content

Commit

Permalink
Build WebKit2 before building WebKit
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=129831
<rdar://problem/15920020>

Reviewed by Dan Bernstein.

.:

* Source/Makefile:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

Tools:

* Scripts/build-webkit:
Always build WebKit2 and make sure to build it before WebKit when building on Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@165220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
[email protected] committed Mar 6, 2014
1 parent 22ff7b5 commit 724b6c9
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 20 deletions.
12 changes: 12 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
2014-03-06 Anders Carlsson <[email protected]>

Build WebKit2 before building WebKit
https://bugs.webkit.org/show_bug.cgi?id=129831
<rdar://problem/15920020>

Reviewed by Dan Bernstein.

* Source/Makefile:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

2014-03-06 Commit Queue <[email protected]>

Unreviewed, rolling out r165193.
Expand Down
2 changes: 1 addition & 1 deletion Source/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebInspectorUI WebKit WebKit2
MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebInspectorUI WebKit2 WebKit

ifneq (,$(findstring iphoneos,$(SDKROOT)))
MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit WebKit2
Expand Down
11 changes: 11 additions & 0 deletions Tools/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
2014-03-06 Anders Carlsson <[email protected]>

Build WebKit2 before building WebKit
https://bugs.webkit.org/show_bug.cgi?id=129831
<rdar://problem/15920020>

Reviewed by Dan Bernstein.

* Scripts/build-webkit:
Always build WebKit2 and make sure to build it before WebKit when building on Mac.

2014-03-06 ChangSeok Oh <[email protected]>

make-3.82 fails to build on ARM/Linux
Expand Down
9 changes: 6 additions & 3 deletions Tools/Scripts/build-webkit
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,17 @@ if (isAppleMacWebKit()) {

# WebKitAdditions must come before WebCore
splice(@projects, 0, 0, "../Internal/WebKitAdditions");
} else {
# WebKit2 should always be built just before WebKit.
my $webKitIndex = first { $projects[$_] eq "Source/WebKit" } 0..$#projects;
splice(@projects, $webKitIndex, 0, "Source/WebKit2");
}

# ANGLE must come before WebCore
splice @projects, 0, 0, "Source/ThirdParty/ANGLE";

if (!isIOSWebKit()) {
# WebKit2 is only supported in SnowLeopard and later at present.
push @projects, ("Source/WebKit2", "Tools/MiniBrowser") if osXVersion()->{"minor"} >= 6 and !$noWebKit2;
push @projects, ("Tools/MiniBrowser");

# WebInspectorUI must come before WebKit and WebKit2
unshift @projects, ("Source/WebInspectorUI");
Expand All @@ -224,7 +227,7 @@ if (isAppleMacWebKit()) {
print(join(" ", @copyLibrariesArgs) . "\n");
(system(@copyLibrariesArgs) == 0) or die;
} else {
push @projects, ("Source/WebKit2") if !$noWebKit2;
push @projects, ("Source/WebKit2");
}

# Build Tools needed for Apple ports
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "9398100A0824BF01008DF038"
BuildableName = "WebKit.framework"
BlueprintName = "WebKit"
ReferencedContainer = "container:Source/WebKit/WebKit.xcodeproj">
BlueprintIdentifier = "1A50DB38110A3C13000D3FE5"
BuildableName = "All"
BlueprintName = "All"
ReferencedContainer = "container:Source/WebKit2/WebKit2.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
Expand All @@ -101,10 +101,10 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "1A50DB38110A3C13000D3FE5"
BuildableName = "All"
BlueprintName = "All"
ReferencedContainer = "container:Source/WebKit2/WebKit2.xcodeproj">
BlueprintIdentifier = "9398100A0824BF01008DF038"
BuildableName = "WebKit.framework"
BlueprintName = "WebKit"
ReferencedContainer = "container:Source/WebKit/WebKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
Expand Down
16 changes: 8 additions & 8 deletions WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "9398100A0824BF01008DF038"
BuildableName = "WebKit.framework"
BlueprintName = "WebKit"
ReferencedContainer = "container:Source/WebKit/WebKit.xcodeproj">
BlueprintIdentifier = "1A50DB38110A3C13000D3FE5"
BuildableName = "All"
BlueprintName = "All"
ReferencedContainer = "container:Source/WebKit2/WebKit2.xcodeproj">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
Expand All @@ -101,10 +101,10 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "1A50DB38110A3C13000D3FE5"
BuildableName = "All"
BlueprintName = "All"
ReferencedContainer = "container:Source/WebKit2/WebKit2.xcodeproj">
BlueprintIdentifier = "9398100A0824BF01008DF038"
BuildableName = "WebKit.framework"
BlueprintName = "WebKit"
ReferencedContainer = "container:Source/WebKit/WebKit.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
Expand Down

0 comments on commit 724b6c9

Please sign in to comment.