Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION (r145541): Incorrect local to device transformation when the SVG is rendered into a separate composited layer #28814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented May 21, 2024

REGRESSION (r145541): Incorrect local to device transformation when the SVG is rendered into a separate composited layer
https://bugs.webkit.org/show_bug.cgi?id=115072
rdar://problem/13717823

Reviewed by NOBODY (OOPS!).

Patch Authored by Said Abou-Hallawa

Inspired by - chromium/chromium@56aadb8

calculateTransformationToOutermostCoordinateSystem() should stop at the
first composited layer to match its backing resolution. Currently, we
are incorrectly taking the layer transform into account (the stop
condition is off by one). This bug is affecting the SVG clipper, masker
and filter.

* Source/WebCore/rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):
* LayoutTests/svg/custom/filter-css-transform-resolution.html: Add Test Case
* LayoutTests/svg/custom/filter-css-transform-resolution-expected.html: Add Test Case Expectation

f8b66c0

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2 βœ… πŸ§ͺ wincairo-tests
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-cairo
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ api-gtk
βœ… πŸ›  watch
βœ… πŸ›  watch-sim

…he SVG is rendered into a separate composited layer

https://bugs.webkit.org/show_bug.cgi?id=115072
rdar://problem/13717823

Reviewed by NOBODY (OOPS!).

Patch Authored by Said Abou-Hallawa

Inspired by - chromium/chromium@56aadb8

calculateTransformationToOutermostCoordinateSystem() should stop at the
first composited layer to match its backing resolution. Currently, we
are incorrectly taking the layer transform into account (the stop
condition is off by one). This bug is affecting the SVG clipper, masker
and filter.

* Source/WebCore/rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):
* LayoutTests/svg/custom/filter-css-transform-resolution.html: Add Test Case
* LayoutTests/svg/custom/filter-css-transform-resolution-expected.html: Add Test Case Expectation
@Ahmad-S792 Ahmad-S792 added the SVG For bugs in the SVG implementation. label May 21, 2024
@Ahmad-S792 Ahmad-S792 self-assigned this May 21, 2024
@Ahmad-S792 Ahmad-S792 changed the title REGRESSION (r145541): Incorrect local to device transformation when t… REGRESSION (r145541): Incorrect local to device transformation when the SVG is rendered into a separate composited layer May 21, 2024
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review May 21, 2024 09:55
@Ahmad-S792
Copy link
Contributor Author

@nikolaszimmermann - I manage to fix it finally. I tried earlier this in - #5761

@Ahmad-S792 Ahmad-S792 requested a review from shallawa May 31, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SVG For bugs in the SVG implementation.
Projects
None yet
2 participants