Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cocoa] Silence some spurious telemetry about reading the "kern.willshutdown" sysctl #28809

Merged
merged 1 commit into from
May 21, 2024
Merged

[Cocoa] Silence some spurious telemetry about reading the "kern.willshutdown" sysctl #28809

merged 1 commit into from
May 21, 2024

Conversation

brentfulgham
Copy link
Contributor

@brentfulgham brentfulgham commented May 20, 2024 •
edited by webkit-early-warning-system

15eafe8

[Cocoa] Silence some spurious telemetry about reading the "kern.willshutdown" sysctl
https://bugs.webkit.org/show_bug.cgi?id=274422
<rdar://122511261>

Reviewed by Per Arne Vollan.

Telemetry confirms we benefit form allowing systcl-read for "kern.willshutdown" under more conditions,
and should allow it.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/279072@main

927e123

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@brentfulgham brentfulgham self-assigned this May 20, 2024
@brentfulgham brentfulgham added the WebKit2 Bugs relating to the WebKit2 API layer label May 20, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 927e123)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

pvollan
pvollan reviewed May 20, 2024
View reviewed changes
Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
@@ -448,7 +448,7 @@
"kern.osversion"
"kern.safeboot"
"kern.version"
"kern.willshutdown" ;; Silence after <rdar://125745970> is resolved.
"kern.willshutdown" ;; <rdar://122511261>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I think it would be good to silence this in the WebContent processes.

pvollan
pvollan approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@brentfulgham brentfulgham added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 21, 2024
@brentfulgham
[Cocoa] Silence some spurious telemetry about reading the "kern.wills…
15eafe8 
…hutdown" sysctl

https://bugs.webkit.org/show_bug.cgi?id=274422
<rdar://122511261>

Reviewed by Per Arne Vollan.

Telemetry confirms we benefit form allowing systcl-read for "kern.willshutdown" under more conditions,
and should allow it.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/279072@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279072@main (15eafe8): https://commits.webkit.org/279072@main

Reviewed commits have been landed. Closing PR #28809 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 15eafe8 into WebKit:main May 21, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvollan pvollan pvollan approved these changes

Assignees

@brentfulgham brentfulgham

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@brentfulgham @webkit-early-warning-system @webkit-commit-queue @pvollan