[JSC] Fix jitCompileSIMDFunction when recompiling the same function with a compiled replacement in different mode #28726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyjorc1
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash d448aca) |
hyjorc1
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
d448aca
to
552350a
Compare
|
EWS run on previous version of this PR (hash 552350a) |
🧪 api-wpe
hyjorc1
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
552350a
to
46daa9e
Compare
|
EWS run on previous version of this PR (hash 46daa9e) |
hyjorc1
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
46daa9e
to
10f4081
Compare
|
EWS run on previous version of this PR (hash 10f4081) |
hyjorc1
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
10f4081
to
69e92c9
Compare
|
EWS run on previous version of this PR (hash 69e92c9) |
hyjorc1
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
69e92c9
to
5594010
Compare
|
EWS run on previous version of this PR (hash 5594010) |
hyjorc1
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
5594010
to
ea3336a
Compare
|
EWS run on current version of this PR (hash ea3336a) |
…ith a compiled replacement in different mode https://bugs.webkit.org/show_bug.cgi?id=274327 rdar://128141991 Reviewed by Mark Lam and Yusuke Suzuki. We might encounter a situation that a WASM SIMD function was previously compiled with the fast memory in a Signaling mode, but failed and tried to recompile the same function in a BoundsChecking mode. In that case, we should allow it to be compiled. To fix this issue, the compilation status should be tracked and updated for each memory mode. This patch fixes all the potential issues among WasmIPIntTierUpCounter.h, WasmLLIntTierUpCounter.h, and WasmTierUpCount.h. * Source/JavaScriptCore/runtime/MemoryMode.h: * Source/JavaScriptCore/wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::work): * Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp: (JSC::IPInt::jitCompileAndSetHeuristics): (JSC::IPInt::WASM_IPINT_EXTERN_CPP_DECL): * Source/JavaScriptCore/wasm/WasmIPIntTierUpCounter.h: (JSC::Wasm::IPIntTierUpCounter::IPIntTierUpCounter): (JSC::Wasm::IPIntTierUpCounter::compilationStatus): (JSC::Wasm::IPIntTierUpCounter::setCompilationStatus): (JSC::Wasm::IPIntTierUpCounter::loopCompilationStatus): (JSC::Wasm::IPIntTierUpCounter::setLoopCompilationStatus): (): Deleted. * Source/JavaScriptCore/wasm/WasmLLIntTierUpCounter.h: (JSC::Wasm::LLIntTierUpCounter::LLIntTierUpCounter): (JSC::Wasm::LLIntTierUpCounter::compilationStatus): (JSC::Wasm::LLIntTierUpCounter::setCompilationStatus): (JSC::Wasm::LLIntTierUpCounter::loopCompilationStatus): (JSC::Wasm::LLIntTierUpCounter::setLoopCompilationStatus): (): Deleted. * Source/JavaScriptCore/wasm/WasmOMGPlan.cpp: (JSC::Wasm::OMGPlan::work): * Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp: (JSC::Wasm::OSREntryPlan::work): * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::triggerOMGReplacementCompile): (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/wasm/WasmPlan.h: (JSC::Wasm::Plan::mode const): * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::jitCompileAndSetHeuristics): (JSC::LLInt::jitCompileSIMDFunction): (JSC::LLInt::WASM_SLOW_PATH_DECL): * Source/JavaScriptCore/wasm/WasmTierUpCount.cpp: (JSC::Wasm::TierUpCount::TierUpCount): * Source/JavaScriptCore/wasm/WasmTierUpCount.h: (JSC::Wasm::TierUpCount::compilationStatusForOMG): (JSC::Wasm::TierUpCount::setCompilationStatusForOMG): (JSC::Wasm::TierUpCount::compilationStatusForOMGForOSREntry): (JSC::Wasm::TierUpCount::setCompilationStatusForOMGForOSREntry): (): Deleted. Canonical link: https://commits.webkit.org/278957@main
webkit-commit-queue
force-pushed
the
eng/JSC-Fix-jitCompileSIMDFunction-when-recompiling-the-same-function-with-a-compiled-replacement-in-different-mode
branch
from
ea3336a
to
b53bf30
Compare
|
Committed 278957@main (b53bf30): https://commits.webkit.org/278957@main Reviewed commits have been landed. Closing PR #28726 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b53bf30
ea3336a