Allow an alternative log location to Documents folder to be specified #161
Conversation
iandundas
requested review from
BasThomas,
AvdLee,
peagasilva,
kairadiagne,
armanarutiunov and
swaan-miller
There was a problem hiding this comment.
Heeeey, welcome as a contributor @iandundas!
This looks good, I'm fine passing in the URL like this 👌 Would you be able to write a test for this as well?
|
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
|
Sorry for delay 🙈 Just pushed a basic test. I can't work out a way to cleanup after the test without hitting this Regardless, it's just a print: the test does pass. 
|
There was a problem hiding this comment.
@iandundas thanks for adding the test file! Could you please add another test to ensure that in the absence of a custom log folder, the default documents folder is used? Thanks in advance!
|
This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
On MacOS, for unsandboxed apps, the log file appears in the
~/Documentsfolder.It would be good to be able to specify an alternative location for the logs to be saved into.
Downside of this approach: two separate definitions setting
logFileLocationto"diagnostics_log.txt", would welcome alternative suggestion.