Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: station and maxbattles display due to changes on it #1071

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

ReuschelCGN
Copy link
Contributor

@ReuschelCGN ReuschelCGN commented Nov 13, 2024

PR needs Feedback! -> no merge till its done

  • remove stations, not seen > 6hrs (adjustment with local.json possible)
  • text info from 9pm - 6am in popup
  • move popup, when no boss on stationmarker
  • fix search for dynaboss in the night
  • change/fix popup timings
  • fix showTimer end_time
    etc....

for testing with docker use this 1:1 image from PR#1071:
ghcr.io/reuschelcgn/reactmap:max-battle-fix-docker

@ReuschelCGN
Copy link
Contributor Author

No feedback ... no one testing

Copy link
Collaborator

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing seems fine. Left some comments.

@@ -2,7 +2,7 @@
<img width="390" alt="ReactMap_Logo" src="https://user-images.githubusercontent.com/58572875/167069223-745a139d-f485-45e3-a25c-93ec4d09779c.png">
</p>

# ReactMap
# ReactMap
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, me no likey!

25374
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be decreasing? @TurtIeSocks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, because one less character in default.json :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though ideally PRs shouldn't be changing this to help avoid merge conflicts. It will update automatically whenever something is merged/committed to dev or main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants