-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: station and maxbattles display due to changes on it #1071
base: develop
Are you sure you want to change the base?
Conversation
No feedback ... no one testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing seems fine. Left some comments.
@@ -2,7 +2,7 @@ | |||
<img width="390" alt="ReactMap_Logo" src="https://user-images.githubusercontent.com/58572875/167069223-745a139d-f485-45e3-a25c-93ec4d09779c.png"> | |||
</p> | |||
|
|||
# ReactMap | |||
# ReactMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, me no likey!
25374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably shouldn't be decreasing? @TurtIeSocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, because one less character in default.json :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though ideally PRs shouldn't be changing this to help avoid merge conflicts. It will update automatically whenever something is merged/committed to dev or main.
PR needs Feedback! -> no merge till its done
etc....
for testing with docker use this 1:1 image from PR#1071:
ghcr.io/reuschelcgn/reactmap:max-battle-fix-docker