Core upgrade xstyled styled components v6 #2436
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
P1X3L
commented
Mar 27, 2024
P1X3L
commented
- use xstyled fork with styled-components v6.1.8
- upgrade styled-components peer dep to v6.1.8
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
P1X3L
force-pushed
the
core-upgrade-xstyled-styled-components-v6
branch
from
6ff3875
to
4d86cd8
Compare
| @@ -19,7 +19,7 @@ Here you'll find all the core components you need to create a delightful webapp. | |||
| 1 - Install the **peer dependencies** listed below: | |||
|
|
|||
| ```bash | |||
| yarn add @xstyled/styled-components react styled-components | |||
| yarn add @wttj/xstyled-styled-components react styled-components | |||
There was a problem hiding this comment.
Not yet but it's will be discuss tomorrow :)
Comment on lines
60
to
62
| */ | ||
| export const system = compose<WuiSystemProps>(...SYSTEM_PROPS) | ||
| /** |
There was a problem hiding this comment.
since we've stopped using it in favor of *Box components; should we remove it from the exports ?
There was a problem hiding this comment.
We still need it to be able to override style props in particular use cases
Comment on lines
+63
to
+66
| ${lines && | ||
| lines !== Infinity && | ||
| Object.keys(lineHeightHeadingsFixer).includes(variant) && | ||
| fixLineHeightStyles(variant)}; |
There was a problem hiding this comment.
i dont understand how this is related to the upgrade ?
There was a problem hiding this comment.
It has nothing to do with the upgrade indeed 🙈
Just couldn't keep up with those g, y, q, j and p being cut
Comment on lines
+3
to
+18
| export const getMax = ( | ||
| width: SystemProp<string | number, Theme>, | ||
| height: SystemProp<string | number, Theme> = width | ||
| ): SystemProp<string | number, Theme> => { | ||
| const typeToValueExtractor: Record< | ||
| string, | ||
| (value: SystemProp<string | number, Theme>) => number | ||
| > = { | ||
| string: (value: string) => parseInt(value, 10), | ||
| number: (value: number): number => value, | ||
| } | ||
| const widthNumber = | ||
| typeToValueExtractor[typeof width as keyof typeof typeToValueExtractor]?.(width) || 0 | ||
| const heightNumber = | ||
| typeToValueExtractor[typeof width as keyof typeof typeToValueExtractor]?.(height) || 0 | ||
| const diff = widthNumber - heightNumber |
There was a problem hiding this comment.
i dont see the problem that has been solved here, could you clarify it ?
There was a problem hiding this comment.
the width andheight arguments were typed as string but have been enriched after the upgrade of xstyled & styled-components resulting in type errors
P1X3L
force-pushed
the
core-upgrade-xstyled-styled-components-v6
branch
from
b81e57c
to
1c313e7
Compare
P1X3L
force-pushed
the
core-upgrade-xstyled-styled-components-v6
branch
from
1c313e7
to
ab2bbbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.