Save pipeline connections in a consistent order #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a problem with logical operations (and linked input sockets in general) having output connections deserialized prior to input connections, which lead to crashes when loading save files with operations that use linked input sockets
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
+ Coverage 54.5% 54.65% +0.14%
==========================================
Files 304 305 +1
Lines 8318 8385 +67
Branches 535 540 +5
==========================================
+ Hits 4534 4583 +49
- Misses 3587 3605 +18
Partials 197 197 |
JLLeitschuh
requested changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem with logical operations (and linked input sockets in general) having output connections deserialized prior to input connections, which lead to crashes when loading save files with operations that use linked input sockets.
Old save files using logical operations remain unusable, but creating a save file with those operations will guarantee a readable save file.
Fixes #919