-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropdown to select map style #1209
base: master
Are you sure you want to change the base?
Conversation
Build succeeded and deployed at https://prism-1209.surge.sh |
@wadhwamatic I updated the branch of this PR to catchup with main. We need to update the |
@ericboucher - I'm not sure what the I think that the order might need to be configurable. In this example, if we change the base to satellite, and try to show layers, they do not appear presumably because the satellite layer is on top. This includes the boundary layer which is hidden I also see that toggling back and forth between styles breaks rendering of admin level data. |
@wadhwamatic yep that's because of the first symbol logic that loops through the different layers in style to find the first symbol and position our admin boundaries and other layers below it. It's currently not updating when you switch style which then creates errors when loading the other layers |
@ericboucher - ok understood. Are you suggesting we create a separate PR to address |
@wadhwamatic this is ready for review. We do a full refresh of the map upon map style selection. However, we currently have the extra map styles in |
Description
This PR adds a drop-down on the navbar to select the map style.
Implement @wadhwamatic 's suggestion: #1199 (comment)
TODO: remove the "street" styles, they are just for test the feature is working. Find working satellite styles.
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn start
REACT_APP_COUNTRY=cambodia yarn start
REACT_APP_COUNTRY=mozambique yarn start
Screenshot/video of feature: