Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'N:' command #2726

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

TKumadaki
Copy link
Contributor

Closes #2725

{
Create("");
_vimBuffer.Process("1");
_vimBuffer.Process(":");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines can be combined into _vimBuffer.Process("1:")

{
Create("");
_vimBuffer.Process("2");
_vimBuffer.Process(":");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines can be combined into _vimBuffer.Process("2:")

@@ -2736,6 +2736,32 @@ with
| Some transaction -> transaction.Complete()
| Option.None -> ()

[<RequireQualifiedAccess>]
type SwitchCommandModeArgument =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create a new type here instead of just expanding the values of ModeArgument?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a correction, but I am not confident.
Because this PR is not urgent,
Please give priority to the release work of 2.8.0.

@TKumadaki
Copy link
Contributor Author

Is the following change better?
Delete ModeArgument.CommandWithCount
Change ModeArgument.PartialCommand of Command: string to:
PartialCommand of Command: string option * Count: int option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: 'N:' command
2 participants