Fix: bad strict comparison String/Number #351
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#350
Summary
What does this PR do/solve?
This PR fix the problem of entity not being selected correctly in the item modal because formik use a string named "related" but compared of Number "id".
I believe the same problem may still occur in other places, there was almost identical PR merged recently: #344.
Maybe it would be a good idea to parse the content type item
id
toString
as soon as it is fetched. That would require addingin https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/blob/master/admin/src/pages/DataManagerProvider/index.js#L219.
I don't know the plugin code well enough, and I'm so I decided to add just the "local" fix for now.
Test Plan
@strapi/strapi 4.11.2
strapi-plugin-navigation 2.2.11
Page
with fieldtitle
of typeText
title
inName fields
in navigation plugin settingsPage
entityPage
entity (this was not the case before the fix, nothing was happening when you clickSave
)