Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Footer #56

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added Footer #56

wants to merge 5 commits into from

Conversation

Avidiptab17
Copy link

Issue no- #27
Created a footer in CyberBear page, modified from index.html, index.css.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @Avidiptab17 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@Avidiptab17
Copy link
Author

Avidiptab17 commented Oct 17, 2024

@Vinay-Khanagavi Sorry to inform I have committed twice because there was a typing issue which I noticed afterwards. Extremely sorry for the inconvenience. Hope you asses my commit. Thank You.

@Vinay-Khanagavi
Copy link
Owner

Vinay-Khanagavi commented Oct 17, 2024

@Avidiptab17 There are too many changes you need to make

Correction

  • Footer width is longer then the homepage
  • And all the social icons should be in same shape as you can see all are in different shape also add discord icon
  • The design of the footer needs to be clean and aligned with our current UI theme

Screenshot 2024-10-18 002148

@Vinay-Khanagavi
Copy link
Owner

Vinay-Khanagavi commented Oct 17, 2024

For design reference :

Screenshot 2024-10-18 002405

@Avidiptab17

@Avidiptab17
Copy link
Author

@Vinay-Khanagavi Hi all the icons are in same size when you open the site. I have adjusted their size in index.css file.
Ok, I am trying to fix the issue. I will try to submit it by today evening.

@Avidiptab17
Copy link
Author

Avidiptab17 commented Oct 18, 2024

For design reference :

Screenshot 2024-10-18 002405

@Avidiptab17

Thank you for the assistance as soon as possible I will try to fix it.

@Avidiptab17
Copy link
Author

Hi please look into the commit. I have tried my best to make it look good. Thank You

@Vinay-Khanagavi
Copy link
Owner

@Avidiptab17 Can you please share screenshot of your changes in #16

@Avidiptab17
Copy link
Author

Avidiptab17 commented Oct 18, 2024

@Avidiptab17 Can you please share screenshot of your changes in #16

Could you please tell me from which part ?

@Vinay-Khanagavi
Copy link
Owner

The UI design @Avidiptab17

@Avidiptab17
Copy link
Author

image

@Vinay-Khanagavi
Copy link
Owner

Remove this all

  • the payment methods, Privacy Policy Terms of Service contact us
  • Sign Up for Free
  • subscribe to get special offers & exclusive deals

You did not change the main which i told you to correct i sent reference image for you to see how social icons looking in the image

  • And all the social icons should be in same shape as you can see all are in different shape also add discord icon

you can get social icons here :https://www.flaticon.com/free-icons/social-media
please make sure all the icons are similar in shape and color

B1N4RY-P4R45173

This comment was marked as outdated.

@Avidiptab17
Copy link
Author

@Vinay-Khanagavi Hi I have already changed what you mentioned do I need the change the color of the footer?

@B1N4RY-P4R45173 B1N4RY-P4R45173 linked an issue Oct 19, 2024 that may be closed by this pull request
@B1N4RY-P4R45173
Copy link
Collaborator

Sorry for accidentally closing the pr

@Avidiptab17
Copy link
Author

@Vinay-Khanagavi Hi I have made the changes as you have advised. Hope you accept this time. Thank You

@B1N4RY-P4R45173
Copy link
Collaborator

{BF266BCC-F296-4D55-A7FB-B0AC1174B1DA}

@Vinay-Khanagavi we need a better color pallet for footer.

@Vinay-Khanagavi
Copy link
Owner

@Avidiptab17 please change the color to grey with white gradient

@Avidiptab17
Copy link
Author

@Vinay-Khanagavi I have made the footer grey with white gradient hope you like this time. Thank You

@B1N4RY-P4R45173
Copy link
Collaborator

Looks Like you messed up a few links
{88647A2B-9F75-4DCE-AB80-967E3BB1B19A}
Sorry but we might require some time to review your pr, and if by any chance you are using AI to code please double check the code, the design (UI) and properly test it before opening up a pr.

You could have added all the images into a folder to keep the directory clean, and also you could have asked us to provide you the links of our socials instead of redirecting them to the homepages.

And Please for the time being don't add any more commits to this pr. I am changing a few things.

@B1N4RY-P4R45173
Copy link
Collaborator

@Vinay-Khanagavi I have made the footer grey with white gradient hope you like this time. Thank You

Unfortunately I don't think it blends well with our home page.

@B1N4RY-P4R45173
Copy link
Collaborator

Please wait for my next reply @Avidiptab17 before you make any changes

@Vinay-Khanagavi Vinay-Khanagavi added the Changes required Pull request is not good enough label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes required Pull request is not good enough hacktoberfest-accepted Hacktoberfest 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Want to make footer
3 participants