-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Footer #56
base: main
Are you sure you want to change the base?
Added Footer #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @Avidiptab17 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
@Vinay-Khanagavi Sorry to inform I have committed twice because there was a typing issue which I noticed afterwards. Extremely sorry for the inconvenience. Hope you asses my commit. Thank You. |
@Avidiptab17 There are too many changes you need to make Correction
|
For design reference : |
@Vinay-Khanagavi Hi all the icons are in same size when you open the site. I have adjusted their size in index.css file. |
Thank you for the assistance as soon as possible I will try to fix it. |
Hi please look into the commit. I have tried my best to make it look good. Thank You |
@Avidiptab17 Can you please share screenshot of your changes in #16 |
Could you please tell me from which part ? |
The UI design @Avidiptab17 |
Remove this all
You did not change the main which i told you to correct i sent reference image for you to see how social icons looking in the image
you can get social icons here :https://www.flaticon.com/free-icons/social-media |
@Vinay-Khanagavi Hi I have already changed what you mentioned do I need the change the color of the footer? |
Sorry for accidentally closing the pr |
@Vinay-Khanagavi Hi I have made the changes as you have advised. Hope you accept this time. Thank You |
@Vinay-Khanagavi we need a better color pallet for footer. |
@Avidiptab17 please change the color to grey with white gradient |
@Vinay-Khanagavi I have made the footer grey with white gradient hope you like this time. Thank You |
Unfortunately I don't think it blends well with our home page. |
Please wait for my next reply @Avidiptab17 before you make any changes |
Issue no- #27
Created a footer in CyberBear page, modified from index.html, index.css.