Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ssh key setup step #131

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

jsgalarraga
Copy link
Contributor

Description

feat: add ssh_key secret input

Fixes #106

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

alestiago
alestiago previously approved these changes Jul 19, 2023
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 💙

LGTM, although I have not tested it. Did you get a chance to test it out?

@jsgalarraga jsgalarraga marked this pull request as ready for review July 19, 2023 13:07
@jsgalarraga
Copy link
Contributor Author

@alestiago Yes, I did test it with and without using the new secret input. In both scenarios worked correctly.

@renancaraujo renancaraujo merged commit 83eede6 into VeryGoodOpenSource:main Jul 20, 2023
@xkxeeshankhan
Copy link

xkxeeshankhan commented Aug 2, 2023

@jsgalarraga Hey man thanks for this but when I try to add the ssh_key I get he below error from the github Actions

Invalid secret, ssh_key is not defined in the referenced workflow.

yaml Snip;

build:
    uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1
    secrets:
      ssh_key: ${{secrets.UI_SSH_KEY}}

@renancaraujo renancaraujo mentioned this pull request Sep 18, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add input for ssh key in order to fetch packages from private repositories
5 participants