Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Gridview Support #82

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shivams1110
Copy link

Status

READY

Description

#79

Added a separate file for support Gridview. The existing flow will not break.

  • InfinteGrid
  • SliverInfinteGrid

Not fixed:-
There is 1 problem right now, the loading widget is not coming center of the screen.

By the way, this is my first open-source contribution. Let me know if there is something I did wrong. I will try to resolve it as soon as possible.

Flutter Doctor:-
[✓] Flutter (Channel stable, 3.24.4, on macOS 15.0 24A335 darwin-arm64, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.66.2)

Always open for feedback.
Thanks

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@shivams1110 shivams1110 requested a review from a team as a code owner November 10, 2024 08:43
@tomarra tomarra added the p2 Important issues not at the top of the work list label Nov 19, 2024
@wolfenrain
Copy link
Member

Hey @shivams1110 thanks for opening this PR, I just reviewed it and it seems to be the same implementation as #51 with some extra parameters.

We closed that one because at the time @renancaraujo could not get the performance of the infinite grid to be within acceptable bounds, have you tried creating bigger sized grids with this implementation?

@shivams1110
Copy link
Author

Hey @shivams1110 thanks for opening this PR, I just reviewed it and it seems to be the same implementation as #51 with some extra parameters.

We closed that one because at the time @renancaraujo could not get the performance of the infinite grid to be within acceptable bounds, have you tried creating bigger sized grids with this implementation?

Hi @wolfenrain
I haven't tried making bigger grids, but I use this approach in my current project.
Please tell me how you will check the performance of the grid for the acceptable bound of the infinite Grid. So that I can check on my side.

Thanks

@renancaraujo
Copy link
Contributor

I don't recall having any performance issues with #51. The reason is that the package is called infinity list, and not grid.

@tomarra
Copy link
Contributor

tomarra commented Dec 9, 2024

@shivams1110 would you mind taking a look at the Pipeline and fix the errors? Looks like there are some analysis issues that need to be resolved.

@tomarra
Copy link
Contributor

tomarra commented Dec 10, 2024

@shivams1110 looks like we still have an error in the pipeline for code coverage.

I don't recall having any performance issues with #51. The reason is that the package is called infinity list, and not grid.

We just talked through this in our planning meeting and were good with moving forward with having a Grid based view in this package. The ask would be that there are some performance tests done in comparing the current list view with the new grid view. This could be done in profile mode with the Flutter Dev Tools in VSCode and ensure that we don't see any big spikes in the performance graphs when it comes to UI jank/delay.

@keiwanmosaddegh
Copy link

We just talked through this in our planning meeting and were good with moving forward with having a Grid based view in this package.

@tomarra this is exciting news, way to go! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Important issues not at the top of the work list
Projects
Status: Community
Development

Successfully merging this pull request may close these issues.

5 participants