-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow very_good create .
#996
Open
a-wallen
wants to merge
4
commits into
VeryGoodOpenSource:main
Choose a base branch
from
a-wallen:allow_create_in_cwd
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rework this. Introducing
.
as aprojectName
and using it to find the name of the directory is kinda confusing because what if I passpath/to/my/folder
instead?.
implies current directory which implicitly also means we can pass any path, which isnt the case. However this is the case forflutter create
so maybe we should just make it that we can pass any given path and use the last part of that path as theprojectName
and create the template at the given path.What you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wolfenrain, thanks for the positive feedback.
I agree, let's do it the same way as the Flutter tool.
This means we'd remove
--output-directory
as an argument.As far as
very_good create <arg>
, here are some requirements that I could implement:arg
.arg
.arg
as the project name.--output-directory
argument.Let me know if you'd like me to proceed. Thanks for catching my oversight 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think that is a good approach, so
arg
would be any type of path indeed, it would be nice if we can keep backwards compatibility with the--output-directory
. Maybe by just checking if it is supplied, if it is show that it is deprecated and just take that over whatever was inarg
, assumingarg
was a path?PS: it would be
very_good create <template> <output directory>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @a-wallen just following up here to see if you are planning on tackling this still?