Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump very_good_analysis from 6.0.0 to 7.0.0 in /packages/dart_frog_cli #1642

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.7.0.0.yaml
analyzer:
exclude:
- lib/src/version.dart
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/e2e/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.7.0.0.yaml
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/e2e/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ dev_dependencies:
meta: ^1.7.0
path: ^1.8.2
test: ^1.19.2
very_good_analysis: ^6.0.0
very_good_analysis: ^7.0.0
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/lib/dart_frog_cli.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
/// # 👀 See usage
/// dart_frog --help
/// ```
library dart_frog_cli;
library;
4 changes: 2 additions & 2 deletions packages/dart_frog_cli/lib/src/command_runner.dart
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DartFrogCommandRunner extends CompletionCommandRunner<int> {
late final int exitCode;
try {
exitCode = await runCommand(argResults) ?? ExitCode.success.code;
} catch (error) {
} on Exception catch (error) {
_logger.err('$error');
exitCode = ExitCode.software.code;
}
Expand Down Expand Up @@ -123,7 +123,7 @@ ${lightYellow.wrap('Changelog:')} $changelogLink
Run ${lightCyan.wrap('$executableName update')} to update''',
);
}
} catch (error, stackTrace) {
} on Exception catch (error, stackTrace) {
_logger.detail(
'[updater] update check error.\n$error\n$stackTrace',
);
Expand Down
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/lib/src/commands/build/build.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class BuildCommand extends DartFrogCommand {

try {
return (await builder.build()).code;
} catch (e) {
} on Exception catch (e) {
logger.err(e.toString());
return ExitCode.software.code;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/dart_frog_cli/lib/src/commands/dev/dev.dart
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class DevCommand extends DartFrogCommand {
try {
await _devServerRunner.start();
return (await _devServerRunner.exitCode).code;
} catch (e) {
} on Exception catch (e) {
logger.err(e.toString());
return ExitCode.software.code;
} finally {
Expand Down
4 changes: 2 additions & 2 deletions packages/dart_frog_cli/lib/src/commands/update/update.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class UpdateCommand extends DartFrogCommand {
late final String latestVersion;
try {
latestVersion = await _pubUpdater.getLatestVersion(packageName);
} catch (error) {
} on Exception catch (error) {
updateCheckProgress.fail();
_logger.err('$error');
return ExitCode.software.code;
Expand All @@ -70,7 +70,7 @@ class UpdateCommand extends DartFrogCommand {
packageName: packageName,
versionConstraint: latestVersion,
);
} catch (error) {
} on Exception catch (error) {
updateProgress.fail();
_logger.err('$error');
return ExitCode.software.code;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class DevServerDomain extends DomainBase {
'applicationId': applicationId,
},
);
} catch (e) {
} on Exception catch (e) {
return DaemonResponse.error(
id: request.id,
error: {
Expand Down Expand Up @@ -149,7 +149,7 @@ class DevServerDomain extends DomainBase {
'applicationId': applicationId,
},
);
} catch (e) {
} on Exception catch (e) {
return DaemonResponse.error(
id: request.id,
error: {
Expand Down Expand Up @@ -186,7 +186,7 @@ class DevServerDomain extends DomainBase {
'exitCode': exitCode.code,
},
);
} catch (e) {
} on Exception catch (e) {
if (!runner.isCompleted) {
_devServerRunners[applicationId] = runner;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class RouteConfigurationDomain extends DomainBase {
},
),
);
} catch (e) {
} on Exception catch (e) {
return DaemonResponse.error(
id: request.id,
error: {
Expand Down Expand Up @@ -183,7 +183,7 @@ class RouteConfigurationDomain extends DomainBase {
'exitCode': exitCode.code,
},
);
} catch (e) {
} on Exception catch (e) {
if (!watcher.isCompleted) {
_routeConfigurationWatchers[watcherId] = watcher;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class RouteConfigurationWatcher {
final projectDirectory = workingDirectory;
try {
routeConfiguration = _routeConfigurationBuilder(projectDirectory);
} catch (error) {
} on Exception catch (error) {
logger.err('$error');
return null;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/dart_frog_cli/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ documentation: https://dartfrog.vgv.dev/docs/overview
topics: [server, backend, shelf, dart-frog, cli]

screenshots:
- description: 'Dart Frog logo.'
- description: "Dart Frog logo."
path: assets/logo.png

environment:
Expand All @@ -34,7 +34,7 @@ dev_dependencies:
build_version: ^2.1.1
mocktail: ^1.0.4
test: ^1.25.8
very_good_analysis: ^6.0.0
very_good_analysis: ^7.0.0

executables:
dart_frog:
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ void main() {
tearDown(() {
try {
tempDir.deleteSync(recursive: true);
} catch (_) {}
} on Exception catch (_) {}
});

test('throws when a pubspec.yaml does not exist', () {
Expand Down
Loading