Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ViewIcons): Group & User DMs icons support #2464

Merged
merged 7 commits into from
May 16, 2024

Conversation

verticalsync
Copy link
Contributor

@verticalsync verticalsync commented May 15, 2024

Lets you view the icon of group channel icons by adding an entry in the context menu called "View Icon".

image
image

@Vendicated
Copy link
Owner

thanks for the contribution!

would be useful to also make this image clickable
image

@verticalsync
Copy link
Contributor Author

verticalsync commented May 15, 2024

thanks for the contribution!

would be useful to also make this image clickable image

I'll try, I've never really made my own patches, and I thought of adding this before but wasn't sure if it should be there.

@verticalsync
Copy link
Contributor Author

verticalsync commented May 15, 2024

Yeah I haven't been able to figure it out (couldn't find the thing to patch) sorry I'm too inexperienced with patches 😭, but if anyone wants to add it go ahead it's also possible for the user icons when you open a normal dm next to username I guess.

@Nuckyz
Copy link
Collaborator

Nuckyz commented May 16, 2024

Yeah I haven't been able to figure it out (couldn't find the thing to patch) sorry I'm too inexperienced with patches 😭, but if anyone wants to add it go ahead it's also possible for the user icons when you open a normal dm next to username I guess.

I did it for you

@Nuckyz Nuckyz changed the title feat(ViewIcons): Add ability to view group channel icon feat(ViewIcons): Group & User DMs icons support May 16, 2024
@Nuckyz Nuckyz enabled auto-merge (squash) May 16, 2024 05:26
@Nuckyz Nuckyz merged commit cddc811 into Vendicated:dev May 16, 2024
1 check passed
@Nuckyz
Copy link
Collaborator

Nuckyz commented May 16, 2024

Thank you for the new feature!

@verticalsync
Copy link
Contributor Author

Yeah I haven't been able to figure it out (couldn't find the thing to patch) sorry I'm too inexperienced with patches 😭, but if anyone wants to add it go ahead it's also possible for the user icons when you open a normal dm next to username I guess.

I did it for you

Thank you 🙏

LunaisLazier pushed a commit to LunaisLazier/Mooncord that referenced this pull request May 21, 2024
ImLvna pushed a commit to ImLvna/Vencord that referenced this pull request May 27, 2024
Autumnlight02 pushed a commit to Autumnlight02/Vencord that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants