fix: Plugins without start/stop function failing to stop/start #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waresnew
changed the title
|
Thanks for the fix! |
LunaisLazier
pushed a commit
to LunaisLazier/Mooncord
that referenced
this pull request
May 21, 2024
ImLvna
pushed a commit
to ImLvna/Vencord
that referenced
this pull request
May 27, 2024
Autumnlight02
pushed a commit
to Autumnlight02/Vencord
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2462
the issue mentioned above applies to all plugins without a start/stop function defined (like MoreKaomoji)
this occurs because the
stopPluginandstartPluginfunctions in plugins/index.ts rely on a stop/start function being defined respectivelyso when I disable VcNarrator, p.started will still be true bc VcNarrator doesn't have a stop() function defined
then when i try to enable it again, it'll error bc it thinks it's already started
fix is to move the
p.started = true/falseto after that if statementthis way if start() errored then it'll return early and won't set p.started (so everything else should still work as intended)