Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowTimeoutDuration: Simplify tooltip style, allow changing style without reload #2441

Merged
merged 4 commits into from
May 16, 2024

Conversation

Sqaaakoi
Copy link
Contributor

@Sqaaakoi Sqaaakoi commented May 11, 2024

The tooltip looked too big and crowded, so I made it simpler

screenshot from my test server

Please do clean up stuff if it is a mess

@Vendicated
Copy link
Owner

could just replace the original tooltip option instead

@Sqaaakoi
Copy link
Contributor Author

could just replace the original tooltip option instead

would you recommend that? i'll start working on that now if you'd rather it that way

@Sqaaakoi Sqaaakoi changed the title ShowTimeoutDuration: Add simplified tooltip style, allow changing style without reload ShowTimeoutDuration: Simplify tooltip style, allow changing style without reload May 11, 2024
@Sqaaakoi Sqaaakoi marked this pull request as draft May 12, 2024 01:08
@Vendicated
Copy link
Owner

why's this still draft?

@Sqaaakoi
Copy link
Contributor Author

yeah i'm only stupid enough to think "hm, maybe this could do with more features" then get overwhelmed trying to reasonably figure out how to make it

@Sqaaakoi Sqaaakoi marked this pull request as ready for review May 14, 2024 23:59
@Sqaaakoi
Copy link
Contributor Author

Sqaaakoi commented May 15, 2024

just merge this (after reviewing and making changes) i'll get around to making my other feature in 3-5 business months

@Nuckyz Nuckyz merged commit 4281b7a into Vendicated:dev May 16, 2024
1 check passed
@Nuckyz
Copy link
Collaborator

Nuckyz commented May 16, 2024

Thanks for the improvements. I took the opportunity to also fix the huge space between the icon and the countdown text

LunaisLazier pushed a commit to LunaisLazier/Mooncord that referenced this pull request May 21, 2024
ImLvna pushed a commit to ImLvna/Vencord that referenced this pull request May 27, 2024
Autumnlight02 pushed a commit to Autumnlight02/Vencord that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants