Rust: Allow running doctests and unit tests #5435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrasnitski
changed the title
cargo:: syntax for build.rs output
|
I guess CI is failing because binja isn't actually installed as part of the GH action? I wouldn't know how to set it up to allow for the linking to succeed - as far as I know the |
mkrasnitski
force-pushed
the
cargo-double-colon
branch
from
1eb4179
to
a5ebb96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
cargo::rustc-link-argoption to the build.rs file of thebinaryninjacrate allows doctests and unit tests to be linked againstbinaryninjacore.so.1and ran when invokingcargo test.Also, the single-colon
cargo:syntax is deprecated as of Rust 1.77, and future features will all use thecargo::syntax. Since the MSRV is already Rust 1.77, it's fine to switch for consistency's sake going forward.