Add subtitle features to declaration file

Vanilagy · Dec 31, 2023 · d695e62 · d695e62
1 parent 80f4e98
commit d695e62
Show file tree

Hide file tree

Showing 7 changed files with 84 additions and 18 deletions.
diff --git a/build/webm-muxer.d.ts b/build/webm-muxer.d.ts
diff --git a/build/webm-muxer.js b/build/webm-muxer.js
diff --git a/build/webm-muxer.min.js b/build/webm-muxer.min.js
diff --git a/build/webm-muxer.min.mjs b/build/webm-muxer.min.mjs
diff --git a/build/webm-muxer.mjs b/build/webm-muxer.mjs
diff --git a/src/muxer.ts b/src/muxer.ts
@@ -485,7 +485,7 @@ export class Muxer<T extends Target> {
  this.#maybeFlushStreamingTargetWriter();
  }
 
- addSubtitleChunk(chunk: EncodedSubtitleChunk, meta: EncodedSubtitleChunkMetadata) {
+ addSubtitleChunk(chunk: EncodedSubtitleChunk, meta: EncodedSubtitleChunkMetadata, timestamp?: number) {
  this.#ensureNotFinalized();
  if (!this.#options.subtitles) throw new Error('No subtitle track declared.');
 
@@ -501,7 +501,7 @@ export class Muxer<T extends Target> {
  let subtitleChunk = this.#createInternalChunk(
  chunk.body,
  'key',
- chunk.timestamp,
+ timestamp ?? chunk.timestamp,
  SUBTITLE_TRACK_NUMBER,
  chunk.duration,
  chunk.additions

diff --git a/src/subtitles.ts b/src/subtitles.ts
@@ -110,7 +110,7 @@ export class SubtitleEncoder {
 
  let chunk: EncodedSubtitleChunk = {
  body: textEncoder.encode(body),
- additions: additions === '\n\n' ? undefined : textEncoder.encode(additions),
+ additions: additions.trim() === '' ? undefined : textEncoder.encode(additions),
  timestamp: startTime * 1000,
  duration: duration * 1000
  };