Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hori Alpha for PS5 #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Hori Alpha for PS5 #42

wants to merge 1 commit into from

Conversation

Duppo
Copy link

@Duppo Duppo commented Oct 8, 2022

Adds Hori Fighting Stick α for PS5.

It has a mode switch so I added the productIDs for all the modes

@smcv
Copy link

smcv commented Apr 6, 2023

If you run

~/.steam/root/ubuntu12_32/steam-runtime/run.sh steam-runtime-input-monitor

with this device unconnected, wait for it to finish describing all your other devices (it should say {"all-for-now": true} at the end), and then connect this device, what additional information is displayed after the {"all-for-now": true} marker?

Press Ctrl+C to stop the input monitor when it has finished displaying the new device(s). Having that information will help to avoid regressions in SDL for this device.

Please repeat for each mode.

@Duppo
Copy link
Author

Duppo commented Apr 6, 2023

Here you go!

PS5 Mode:
{
  "added" : {
    "interface_flags" : [
      "raw-hid",
      "readable",
      "read-write"
    ],
    "type_flags" : [
    ],
    "dev_node" : "/dev/hidraw5",
    "subsystem" : "hidraw",
    "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:0184.000D/hidraw/hidraw5",
    "bus_type" : "0x0003",
    "vendor_id" : "0x0f0d",
    "product_id" : "0x0184",
    "version" : "0x0116",
    "hid_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:0184.000D",
      "name" : "HORI CO.,LTD. HORI FIGHTING STICK α",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x0184",
      "uniq" : ""
    },
    "usb_device_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x0184",
      "version" : "0x0116",
      "manufacturer" : "HORI CO.,LTD.",
      "product" : "HORI FIGHTING STICK α",
      "serial" : null
    }
  }
}
{
  "added" : {
    "interface_flags" : [
      "event",
      "readable",
      "read-write"
    ],
    "type_flags" : [
      "joystick"
    ],
    "dev_node" : "/dev/input/event17",
    "subsystem" : "input",
    "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:0184.000D/input/input33/event17",
    "bus_type" : "0x0003",
    "vendor_id" : "0x0f0d",
    "product_id" : "0x0184",
    "version" : "0x0111",
    "evdev" : {
      "types" : [
        "SYN",
        "KEY",
        "ABS",
        "MSC"
      ],
      "absolute_axes" : [
        "X",
        "Y",
        "Z",
        "RX",
        "RY",
        "RZ",
        "HAT0X",
        "HAT0Y"
      ],
      "relative_axes" : [
      ],
      "keys" : [
        "BTN_A",
        "BTN_B",
        "BTN_C",
        "BTN_X",
        "BTN_Y",
        "BTN_Z",
        "BTN_TL",
        "BTN_TR",
        "BTN_TL2",
        "BTN_TR2",
        "BTN_SELECT",
        "BTN_START",
        "BTN_MODE",
        "BTN_THUMBL"
      ],
      "input_properties" : [
      ]
    },
    "hid_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:0184.000D",
      "name" : "HORI CO.,LTD. HORI FIGHTING STICK α",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x0184",
      "uniq" : ""
    },
    "input_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:0184.000D/input/input33",
      "name" : "HORI CO.,LTD. HORI FIGHTING STICK α",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x0184",
      "version" : "0x0111"
    },
    "usb_device_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x0184",
      "version" : "0x0116",
      "manufacturer" : "HORI CO.,LTD.",
      "product" : "HORI FIGHTING STICK α",
      "serial" : null
    }
  }
}
PS4 Mode:
{
  "added" : {
    "interface_flags" : [
      "raw-hid",
      "readable",
      "read-write"
    ],
    "type_flags" : [
    ],
    "dev_node" : "/dev/hidraw5",
    "subsystem" : "hidraw",
    "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:011C.000E/hidraw/hidraw5",
    "bus_type" : "0x0003",
    "vendor_id" : "0x0f0d",
    "product_id" : "0x011c",
    "version" : "0x0116",
    "hid_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:011C.000E",
      "name" : "HORI CO.,LTD. HORI FIGHTING STICK α",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011c",
      "uniq" : ""
    },
    "usb_device_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011c",
      "version" : "0x0116",
      "manufacturer" : "HORI CO.,LTD.",
      "product" : "HORI FIGHTING STICK α",
      "serial" : null
    }
  }
}
{
  "added" : {
    "interface_flags" : [
      "event",
      "readable",
      "read-write"
    ],
    "type_flags" : [
      "joystick"
    ],
    "dev_node" : "/dev/input/event17",
    "subsystem" : "input",
    "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:011C.000E/input/input34/event17",
    "bus_type" : "0x0003",
    "vendor_id" : "0x0f0d",
    "product_id" : "0x011c",
    "version" : "0x1101",
    "evdev" : {
      "types" : [
        "SYN",
        "KEY",
        "ABS",
        "MSC"
      ],
      "absolute_axes" : [
        "X",
        "Y",
        "Z",
        "RX",
        "RY",
        "RZ",
        "HAT0X",
        "HAT0Y"
      ],
      "relative_axes" : [
      ],
      "keys" : [
        "BTN_A",
        "BTN_B",
        "BTN_C",
        "BTN_X",
        "BTN_Y",
        "BTN_Z",
        "BTN_TL",
        "BTN_TR",
        "BTN_TL2",
        "BTN_TR2",
        "BTN_SELECT",
        "BTN_START",
        "BTN_MODE",
        "BTN_THUMBL"
      ],
      "input_properties" : [
      ]
    },
    "hid_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:011C.000E",
      "name" : "HORI CO.,LTD. HORI FIGHTING STICK α",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011c",
      "uniq" : ""
    },
    "input_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.3/0003:0F0D:011C.000E/input/input34",
      "name" : "HORI CO.,LTD. HORI FIGHTING STICK α",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011c",
      "version" : "0x1101"
    },
    "usb_device_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011c",
      "version" : "0x0116",
      "manufacturer" : "HORI CO.,LTD.",
      "product" : "HORI FIGHTING STICK α",
      "serial" : null
    }
  }
}
PC Mode:
{
  "added" : {
    "interface_flags" : [
      "event",
      "readable",
      "read-write"
    ],
    "type_flags" : [
      "joystick"
    ],
    "dev_node" : "/dev/input/event17",
    "subsystem" : "input",
    "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.0/input/input35/event17",
    "bus_type" : "0x0003",
    "vendor_id" : "0x0f0d",
    "product_id" : "0x011e",
    "version" : "0x0116",
    "evdev" : {
      "types" : [
        "SYN",
        "KEY",
        "ABS",
        "FF"
      ],
      "absolute_axes" : [
        "X",
        "Y",
        "Z",
        "RX",
        "RY",
        "RZ",
        "HAT0X",
        "HAT0Y"
      ],
      "relative_axes" : [
      ],
      "keys" : [
        "BTN_A",
        "BTN_B",
        "BTN_X",
        "BTN_Y",
        "BTN_TL",
        "BTN_TR",
        "BTN_SELECT",
        "BTN_START",
        "BTN_MODE",
        "BTN_THUMBL",
        "BTN_THUMBR"
      ],
      "input_properties" : [
      ]
    },
    "input_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2/3-2:1.0/input/input35",
      "name" : "Generic X-Box pad",
      "bus_type" : "0x0003",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011e",
      "version" : "0x0116"
    },
    "usb_device_ancestor" : {
      "sys_path" : "/sys/devices/pci0000:00/0000:00:08.1/0000:07:00.4/usb3/3-2",
      "vendor_id" : "0x0f0d",
      "product_id" : "0x011e",
      "version" : "0x0116",
      "manufacturer" : "HORI CO.,LTD.",
      "product" : "HORI FIGHTING STICK α",
      "serial" : null
    }
  }
}

@smcv
Copy link

smcv commented Apr 11, 2023

Thanks, I'll add those to the test data in SDL and steam-runtime-tools to make sure their heuristic continues to identify it as a gaming controller.

@saml, @TTimo: are fighting controllers like this one in-scope for steam-devices, or is this repo intended to cover only controllers that would be appropriate for Steam Input (basically the same scope as SDL_Gamepad) and SteamVR?

@smcv
Copy link

smcv commented Apr 12, 2023

It looks as though we include fighting controllers in this repo if they're broadly compatible with the controllers that Steam Input expects (Xbox, Playstation or Switch family), even if they're not really the same shape as the devices that Steam Input wants to deal with.

@smcv
Copy link

smcv commented Apr 12, 2023

I'll add those to the test data in SDL and steam-runtime-tools to make sure their heuristic continues to identify it as a gaming controller

This is libsdl-org/SDL#7597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants