Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error for Convertion from palo to checkpoint. #8

Merged
merged 12 commits into from
Jul 26, 2024

Conversation

mymyke
Copy link
Contributor

@mymyke mymyke commented Jun 15, 2024

Wrong variable was used. policy_src_address instead of policy_source_address

Wrong variable was used policy_src_address  instead of policy_source_address
Palo converter does not add "/32" to Addresses that should be host IPs. But checkpoint needs the "/32" to convert it to hosts.
Also Palo supports Host-IPs with network masks and checkpoint does not. So thoose need to be convertet to "/32" adresses as well.
Servicegroups got added to network_groups instead.
…t used it gets replaced with policy_src_address everywhere
@VahidTa
Copy link
Owner

VahidTa commented Jun 16, 2024

First of all thanks for your contribution to this project.
Additionally, the codebase is not well structured as it is almost my first Python project.

please attach the input/output file and the version you have tested. (before your change and after)

@mymyke
Copy link
Contributor Author

mymyke commented Jun 28, 2024

I added the input File and the Output files that get created when using my fixed verision.
I can't add output files for your Version, since its not running through, but instead throws errors.

PAN OS Version used for the config is 11.0.4-h1

Copy link
Owner

@VahidTa VahidTa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the input/output files from the PR. Thanks for sharing. My point was to attach the input/output files to comments.

@mymyke
Copy link
Contributor Author

mymyke commented Jun 30, 2024

@VahidTa
Copy link
Owner

VahidTa commented Jun 30, 2024

put back .keep file under "exported"

@VahidTa
Copy link
Owner

VahidTa commented Jul 16, 2024

Please remove the ".keep" file under the "exported" directory. Otherwise, I can't merge it and I'll close the MR

destination_address_list was used instead of service_address_list
Checkpoint needs Any to be written with an Uppercase A at the beginning.

Also palo alto's "application-default" option does not exist on checkpoint. Added translation to "Any"
@mymyke
Copy link
Contributor Author

mymyke commented Jul 26, 2024

I put back .keep file under "exported". Hope that helps

@VahidTa VahidTa merged commit 06f0ff0 into VahidTa:main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants