Add comment support for file_to_skip for visibility #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kunal Kotwani <[email protected]>
VachaShah
reviewed
Apr 11, 2024
There was a problem hiding this comment.
files_to_skip is an optional parameter supplied by the user to skip certain files while backport. I feel in this PR it considers files to skip as the files skipped to make the backport succeed which might be misleading. Let me know if I am misunderstanding this.
| /* eslint-disable no-await-in-loop */ | ||
| for (const file of filesToSkip) { | ||
| await git("checkout", "HEAD", file); | ||
| if (partialBackport) { |
There was a problem hiding this comment.
Would this not change the behavior for filesToSkip?
|
Hi @kotwanikunal, still looking to finish this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.