Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a lot of issues about the general concept of allowing more message control (i.e., #255, #192, and some in the rust_hdl_vscode repository). This is an attempt at tackling the challenge of allowing message control of sorts. Once all is set and done, I envision a process where you can
vhdl_ls.toml
, i.e.,(Note that the syntax for both examples is just for illustrative purposes and subject to change should these features be implemented).
This PR
This PR introduces error codes. Except for being forwarded to the language server and potentially being displayed, this is unused. However, I plan to add additional functionality that uses these error codes. This is to avoid error prone regex matching or similar when detecting an error that should be ignored or downgraded:
I will leave this PR open for some time to collect some feedback, especially concerning how current errors without error codes are assigned to the different error codes. Later changes to the actual codes that are not purely additive (i.e., merging of two error codes, splitting an error code into multiple, ...) are not desirable as this will cause backwards incompatible changes. If no such feedback is given, I will assume that these error codes are a good start.