Expose new LoadingPageComponentType
and ErrorPageComponentType
types
#84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with the
PageComponent
type not allowing for theerror
prop, that's used for error page componentsRelated issues
Addresses #56
What this does
RouteError
to export, removesRecord<string, any>
fromRouteError
type definition (this can only ever be a string or null)LoadingPageComponentType
andErrorPageComponentType
types to describe the type of React component expected (added to export)PageComponent
to use specificLoadingPageComponent
orErrorPageComponent
typesNotFound
to useerror
propstylelint
referenceHow to test
npm i
,npm run bootstrap
,npm start
)/demos/intermediate/src/router/index.tsx
NotFound
component intoerror
prop