Don't depend on unbounded-delays for riscv64 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64-bit RISC-V should fall into the same case in UnkindPartition#344 and should be added here. Tested locally.
felixonmars
added a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Jun 22, 2023
Don't depend on unbounded-delays for riscv64. Upstreamed as UnkindPartition/tasty#371
felixonmars
added a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Jun 22, 2023
Don't depend on unbounded-delays for riscv64. Upstreamed as UnkindPartition/tasty#371
@felixonmars you need to raise a Cabal PR first, adding a new architecture. |
|
I actually thought I did... Now opened as haskell/cabal#9062 |
|
@amesgen @TerrorJack any ideas what's up with our WASM CI job? |
Ah sorry, this is due to a bindist artifact expiration. I have an upstream MR to fix this properly in ghc-wasm-meta. This should be merged soon-ish; will create a PR as soon as it. To fix this immediately, one can bump tasty/.github/workflows/ci.yaml Line 86 in b509e04 to bd9533e34df53694a4c7e4102fced1fdc0596024, do you want to do this here or shall I create a PR? |
|
It would be great if you raise a separate PR, thanks. |
Merged
|
Unfortunately, this would have to wait not only until Cabal 3.12 release itself (which is soon), but until Hackage upgrades to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
64-bit RISC-V should fall into the same case in
#344 and should be added here. Tested locally.