Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicate SIGINT to the parent shell #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

UnkindPartition
Copy link
Owner

This is the current work I have for #309. Please review and test it well before merging; I don't remember (and can't test right now) if it actually worked.

@santiweight
Copy link

Thank you for this! I will try to test this out on Monday at work. If I don't respond in a couple days and you still want review, please ping :)

@VictorCMiraldo
Copy link
Collaborator

I'd love to write a test for this, but my attempts behave the same at master and on this branch. I've tried:

  • Write a testGroup that launches processes, then manually send SIGINT: I see the entire process killed and get my shell back in both branches
  • Write a testGroup with one test that sends SIGINT to $$, only that test fails on both branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants