Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CONTRIBUTING.md as per April Community Call discussion. #985

Merged

Conversation

demiankatz
Copy link
Contributor

As discussed on today's Community Call, this PR makes some improvements to CONTRIBUTING.md to make it more helpful. It adjusts heading levels for consistency, adds a note about the destination of the distribution build, explains our Git workflows, removes some old comments, and includes a few other minor adjustments.

Feedback is welcome!

Copy link

codesandbox bot commented Apr 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:02pm

Copy link

codesandbox-ci bot commented Apr 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@demiankatz
Copy link
Contributor Author

I think more discussion is needed on the release process -- particularly whether we bump the version in the dev branch before merging to main, or if we need to merge main back into dev after bumping the version. I can see arguments for or against either approach.

@demiankatz demiankatz requested a review from edsilv April 4, 2024 18:08
@jamesmisson
Copy link
Contributor

Thanks @demiankatz, I think these are all improvements, I'll go ahead and merge

@jamesmisson jamesmisson merged commit d4e1211 into UniversalViewer:dev Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants