Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposal for #929 #975

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

nicolasfranck
Copy link
Contributor

Description of what you did:

  • This is a fix proposal for thumbnails not reloaded after login #929 were I introduce a cache key in the content-left-panel that is only changed after a login event. This should be added to the thumbnail uri. Not sure if this works with all urls as I merely append ?t=<timestamp> to the thumbnail uri, and I know that some people use query parameters in their iiif image api url's (because directly passed to an iipsrv). e.g. https://myhost/?IIIF=?t=timestamp

Copy link

codesandbox bot commented Mar 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 6:23pm

Copy link

codesandbox-ci bot commented Mar 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@demiankatz
Copy link
Contributor

Thanks, @nicolasfranck! I think the questions we now need to answer (which might require input from others) are whether there are other situations where we should invalidate the cache, and whether this replaces the existing config setting, or if it should perhaps be incorporated with it (e.g. if the thumbnail cache invalidation setting is disabled, should that prevent us from adding the extra parameter to thumbs?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants