Upgrading to Openseadragon v4 #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Thanks, @404mike -- I noticed that build is failing here -- I think the comment below explains why. Let me know if I can do more to help!
| @@ -110,7 +110,7 @@ | |||
| "manifesto.js": "4.2.16", | |||
| "mediaelement": "4.2.15", | |||
| "mediaelement-plugins": "2.5.1", | |||
| "openseadragon": "2.4.2", | |||
| "openseadragon": "4.0.0", | |||
There was a problem hiding this comment.
I think you also need to commit changes to package-lock.json in order for this to fully work.
|
@404mike Could report on progress on this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade openseadragon dependancy to version
4.0.0. Current version2.4.2containsevalfunction in production release. Openseadragon has removed this code in its latest release.