Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image adjustment and fix to "Home Button" #1052

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

ra-anders
Copy link

Added a new function for image adjustment (contrast, brightness and saturation) and fixed the existing "Go Home" button (css was missing). To enable it you set these properties:

"openSeadragonCenterPanel": {
      "options": {
        ...
        "showHomeControl": true,
        "showAdjustImageControl": true
        ...
      }
    },

In the dialogue for image adjustment the user have the choice to save the settings (this only works if "saveUserSettings" is set to true).

image

image

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 11:45am

Copy link
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried this hands-on yet, but the code makes sense to me. Just a few questions/suggestions regarding finishing touches.

src/locales/cy-GB.json Outdated Show resolved Hide resolved
src/locales/fr-FR.json Outdated Show resolved Hide resolved
src/uv-iiif-config.json Show resolved Hide resolved
@demiankatz
Copy link
Contributor

demiankatz commented Jun 27, 2024

Also, the description of this PR mentions a fix to "Home Button," but I didn't immediately see exactly what was being fixed. Can you elaborate? (Just might be useful to understand what was broken and what has been fixed, especially if it's an opportunity to build a test to catch regressions).

@ra-anders
Copy link
Author

Also, the description of this PR mentions a fix to "Home Button," but I didn't immediately see exactly what was being fixed. Can you elaborate? (Just might be useful to understand what was broken and what has been fixed, especially if it's an opportunity to build a test to catch regressions).

Basically all I did was to add the CSS to display it, it was missing for some reason. But all the functionality was there.

                    .xl-mediaquery({
                        display: inline-block !important;
                        cursor: pointer !important;
                        background-image: data-uri('../img/home.png') !important;
                        width: 28px;
                        height: 28px;
                        // margin: 3px !important;
                        img {
                            display: none;
                        }
                        &:focus {
                            .tab-focus();
                        }
                    });

@demiankatz
Copy link
Contributor

Thanks for the adjustments and clarifications, @ra-anders! As I noted at our meeting yesterday, the Steering Group is working through new processes for getting pull requests reviewed and merged, so it may take us a little while to get this finalized... but I think this will be a good candidate for fairly early merging once we get that sorted out. In the meantime, I'll add this to our project board so we don't lose track of it!

@LanieOkorodudu
Copy link
Collaborator

I just tested this adjustments features in different browser such as Chrome, Edge, and Firefox. Looks all good. Thanks for your awesome job @ra-anders

@demiankatz
Copy link
Contributor

Thanks, @LanieOkorodudu, that's great! I think then the only thing we might want to talk about further before merging this is how our translation workflow should be handled. I'll note that in the steering group channel on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In testing
Development

Successfully merging this pull request may close these issues.

None yet

3 participants